From 01bb3d4f235424b1f72ab0c08d968d38a8deba45 Mon Sep 17 00:00:00 2001
From: Daniel Cronqvist <dancro99@gmail.com>
Date: Mon, 2 Sep 2024 21:14:56 +0200
Subject: [PATCH] Add better default loader creation

---
 src/DotTiled/Serialization/Loader.cs | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/src/DotTiled/Serialization/Loader.cs b/src/DotTiled/Serialization/Loader.cs
index 8b4b9f0..7651c3e 100644
--- a/src/DotTiled/Serialization/Loader.cs
+++ b/src/DotTiled/Serialization/Loader.cs
@@ -32,11 +32,26 @@ public class Loader
   }
 
   /// <summary>
-  /// Creates a new instance of a <see cref="Loader"/> with the default <see cref="FileSystemResourceReader"/> and <see cref="DefaultResourceCache"/>.
+  /// Creates a new instance of a <see cref="Loader"/> with the default <see cref="FileSystemResourceReader"/> and <see cref="DefaultResourceCache"/>, and no available custom type definitions.
   /// </summary>
-  /// <param name="customTypeDefinitions">An optional collection of custom type definitions that can be used to resolve custom types in Tiled resources.</param>
   /// <returns>A new instance of a <see cref="Loader"/>.</returns>
-  public static Loader Default(IEnumerable<ICustomTypeDefinition> customTypeDefinitions = null) => new Loader(new FileSystemResourceReader(), new DefaultResourceCache(), customTypeDefinitions ?? []);
+  public static Loader Default() => new Loader(new FileSystemResourceReader(), new DefaultResourceCache(), []);
+
+  /// <summary>
+  /// Creates a new instance of a <see cref="Loader"/> with the ability to override the default <see cref="FileSystemResourceReader"/>, <see cref="DefaultResourceCache"/>, and custom type definitions.
+  /// </summary>
+  /// <param name="resourceReader">A reader that is able to read Tiled resources from a given path.</param>
+  /// <param name="resourceCache">A cache that stores Tiled resources for faster retrieval and reuse.</param>
+  /// <param name="customTypeDefinitions">A collection of custom type definitions that can be used to resolve custom types in Tiled resources.</param>
+  /// <returns></returns>
+  public static Loader DefaultWith(
+    IResourceReader resourceReader = null,
+    IResourceCache resourceCache = null,
+    IEnumerable<ICustomTypeDefinition> customTypeDefinitions = null) =>
+    new Loader(
+      resourceReader ?? new FileSystemResourceReader(),
+      resourceCache ?? new DefaultResourceCache(),
+      customTypeDefinitions ?? Array.Empty<ICustomTypeDefinition>());
 
   /// <summary>
   /// Loads a map from the given <paramref name="mapPath"/>.